This requres exec-ing python, which in a trace I ran of the CMake re-configure time took ~2% of the reconfigure time.
Details
Details
- Reviewers
phosek smeenai compnerd - Commits
- rZORG4c2a89997f26: [CMake] Detecting python modules should be cached
rZORGa25efa6f44d5: [CMake] Detecting python modules should be cached
rG4c2a89997f26: [CMake] Detecting python modules should be cached
rGa25efa6f44d5: [CMake] Detecting python modules should be cached
rGbec30c4af1e3: [CMake] Detecting python modules should be cached
rL360196: [CMake] Detecting python modules should be cached
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
While there it really asks to be rewritten into a proper FindPythonModule.cmake module.
Comment Actions
@lebedev.ri - yeah, that would certainly be nicer to extract this into a separate module, I don't think that it should block this. It would be a great follow up.