Page MenuHomePhabricator

[lldb] [lit] Split 'register read' tests between zmm*, xmm16+, ymm16+
ClosedPublic

Authored by mgorny on May 1 2019, 7:04 AM.

Details

Summary

Since Darwin target implements support for zmm* registers without
matching support for the respectively added xmm* and ymm* registers,
split the tests for each register group. To reduce code duplication,
the tests are using the same source file (which sets more registers
than necessary but that should not cause any harm).

Diff Detail

Repository
rLLDB LLDB

Event Timeline

mgorny created this revision.May 1 2019, 7:04 AM
labath accepted this revision.May 2 2019, 12:33 AM

Thanks for splitting these. Since we deleted the zmm dotest tests, I think it's important to do this so we don't regress test coverage on darwin. (But somebody on the darwin side should take a look at adding support for [xy]mm registers too, as I expect their exclusion was just an omission, and fixing that might be as simple as defining a couple of new RegisterInfo structs)

This revision is now accepted and ready to land.May 2 2019, 12:33 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 2 2019, 4:25 AM
Herald added a subscriber: teemperor. · View Herald Transcript