Page MenuHomePhabricator

[ThinLTO] Fix unreachable code when parsing summary entries.
ClosedPublic

Authored by tejohnson on Apr 30 2019, 5:22 PM.

Details

Summary

Early returns were causing some code to be skipped. This was missed
since the summary entries are typically at the end of the llvm assembly
file.

Fixes PR41663.

Diff Detail

Repository
rL LLVM

Event Timeline

tejohnson created this revision.Apr 30 2019, 5:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 30 2019, 5:22 PM
andreadb added a reviewer: wristow.
andreadb added a subscriber: andreadb.
wristow accepted this revision.May 1 2019, 9:21 AM

Seems pretty straightforward and clearly correct.
LGTM

This revision is now accepted and ready to land.May 1 2019, 9:21 AM
This revision was automatically updated to reflect the committed changes.