This is an archive of the discontinued LLVM Phabricator instance.

[libFuzzer] Disable i386 on non-Linux platforms
ClosedPublic

Authored by metzman on Apr 30 2019, 4:52 PM.

Download Raw Diff

Details

Reviewers

morehouse
rnk

Commits

rGa5147e0e1564: [libFuzzer] Disable i386 on non-Linux platforms
rCRT359641: [libFuzzer] Disable i386 on non-Linux platforms
rL359641: [libFuzzer] Disable i386 on non-Linux platforms

Summary

Disable i386 on non-Linux platforms since it is unwanted and broken on Windows.

Diff Detail

Repository: rL LLVM

Event Timeline

metzman created this revision.Apr 30 2019, 4:52 PM

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 30 2019, 4:52 PM

Herald added subscribers: llvm-commits, Restricted Project, mgorny. · View Herald Transcript

Harbormaster completed remote builds in B31217: Diff 197486.Apr 30 2019, 4:53 PM

metzman retitled this revision from [libFuzzer] Disable i386 on Windows to [libFuzzer] Disable i386 on non-Linux platforms.Apr 30 2019, 4:54 PM

metzman edited the summary of this revision. (Show Details)

Please take a look.
I could be less conservative here and only disable i386 on Windows but I frankly don't think the risk of breaking other platforms is worth the benefit (nothing).
This is intended to fix https://bugs.chromium.org/p/chromium/issues/detail?id=957971#c5 I've verified that the "fuzzer" target is no longer possible to build on x86 (as opposed to possible but failing as it was before).
It's also worth noting that this breakage is in part caused by libFuzzer building with MSVC (__builtin_clzll isn't supported by MSVC but _BitScanReverse64 is supported, but not on i386) instead of indirectly with clang.

LGTM.

This revision is now accepted and ready to land.Apr 30 2019, 5:34 PM

I'm also thinking i386 libFuzzer is broken on iOS (though I have no way of confirming this) and thus caused the greendragon bot failure: http://green.lab.llvm.org/green/job/clang-stage2-coverage-R/3958/consoleFull#console-section-35

Closed by commit rL359641: [libFuzzer] Disable i386 on non-Linux platforms (authored by metzman). · Explain WhyApr 30 2019, 6:38 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: delcypher. · View Herald TranscriptApr 30 2019, 6:38 PM

metzman marked an inline comment as done.Apr 30 2019, 7:47 PM

metzman added inline comments.

compiler-rt/trunk/cmake/config-ix.cmake
234	This is a bug. "LINUX" is undefined here. But it solved an unrelated issue caused by i386 on Linux bots so I'll need to fix that before I correct this code.

Revision Contents

Path

Size

compiler-rt/

trunk/

cmake/

config-ix.cmake

6 lines

Diff 197496

compiler-rt/trunk/cmake/config-ix.cmake

	Show First 20 Lines • Show All 225 Lines • ▼ Show 20 Lines
	endif()			endif()

	set(ALL_SANITIZER_COMMON_SUPPORTED_ARCH ${X86} ${X86_64} ${PPC64}			set(ALL_SANITIZER_COMMON_SUPPORTED_ARCH ${X86} ${X86_64} ${PPC64}
	${ARM32} ${ARM64} ${MIPS32} ${MIPS64} ${S390X})			${ARM32} ${ARM64} ${MIPS32} ${MIPS64} ${S390X})
	set(ALL_ASAN_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64}			set(ALL_ASAN_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64}
	${MIPS32} ${MIPS64} ${PPC64} ${S390X})			${MIPS32} ${MIPS64} ${PPC64} ${S390X})
	set(ALL_CRT_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64})			set(ALL_CRT_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64})
	set(ALL_DFSAN_SUPPORTED_ARCH ${X86_64} ${MIPS64} ${ARM64})			set(ALL_DFSAN_SUPPORTED_ARCH ${X86_64} ${MIPS64} ${ARM64})
				if(LINUX)
				metzmanAuthorUnsubmitted Done Reply Inline Actions This is a bug. "LINUX" is undefined here. But it solved an unrelated issue caused by i386 on Linux bots so I'll need to fix that before I correct this code. metzman: This is a bug. "LINUX" is undefined here. But it solved an unrelated issue caused by i386 on…
	set(ALL_FUZZER_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM64})			set(ALL_FUZZER_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM64})
				else()
				set(ALL_FUZZER_SUPPORTED_ARCH ${X86_64} ${ARM64})
				endif()

	if(APPLE)			if(APPLE)
	set(ALL_LSAN_SUPPORTED_ARCH ${X86} ${X86_64} ${MIPS64} ${ARM64})			set(ALL_LSAN_SUPPORTED_ARCH ${X86} ${X86_64} ${MIPS64} ${ARM64})
	else()			else()
	set(ALL_LSAN_SUPPORTED_ARCH ${X86} ${X86_64} ${MIPS64} ${ARM64} ${ARM32} ${PPC64})			set(ALL_LSAN_SUPPORTED_ARCH ${X86} ${X86_64} ${MIPS64} ${ARM64} ${ARM32} ${PPC64})
	endif()			endif()
	set(ALL_MSAN_SUPPORTED_ARCH ${X86_64} ${MIPS64} ${ARM64} ${PPC64})			set(ALL_MSAN_SUPPORTED_ARCH ${X86_64} ${MIPS64} ${ARM64} ${PPC64})
	set(ALL_HWASAN_SUPPORTED_ARCH ${X86_64} ${ARM64})			set(ALL_HWASAN_SUPPORTED_ARCH ${X86_64} ${ARM64})
	▲ Show 20 Lines • Show All 431 Lines • Show Last 20 Lines