Page MenuHomePhabricator

[yaml2obj] - Report when unknown section is referenced from program header declaration block.
ClosedPublic

Authored by grimar on Apr 30 2019, 9:45 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

grimar created this revision.Apr 30 2019, 9:45 AM
jhenderson accepted this revision.Apr 30 2019, 9:58 AM

LGTM. This looks much better.

This revision is now accepted and ready to land.Apr 30 2019, 9:58 AM
grimar updated this revision to Diff 197368.EditedApr 30 2019, 10:27 AM

Sorry, during final test run I found this fix reveals a bug in one of the testcases: llvm-objcopy/ELF/no-build-id.test
I fixed it. Could you review this change please too?

grimar requested review of this revision.Apr 30 2019, 10:27 AM
rupprecht accepted this revision.Apr 30 2019, 3:43 PM

llvm-objcopy test looks fine

This revision is now accepted and ready to land.Apr 30 2019, 3:43 PM
jhenderson added inline comments.May 1 2019, 1:36 AM
test/tools/llvm-objcopy/ELF/no-build-id.test
13 ↗(On Diff #197368)

If you want to leave it as is, then fine, but I'd actually prefer the section name be changed to .note.foo in both cases, not .note.gnu.foo, since the "gnu" bit implies something specific to do with GNU which isn't the case.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 1 2019, 2:45 AM
grimar marked an inline comment as done.May 1 2019, 2:47 AM
grimar added inline comments.
test/tools/llvm-objcopy/ELF/no-build-id.test
13 ↗(On Diff #197368)

I changed the name as you suggested before the commit.