[OpenCL][PR41609] Deduce static data members to __global addr space

[Anastasia]

Summary

Similarly to static variables in OpenCL, static class data members should be deduced to __global addr space.

[rjmccall]

Presumably a similar rule would apply to thread-locals if you supported them.

[Anastasia]

In D61304#1485125, @rjmccall wrote:

Presumably a similar rule would apply to thread-locals if you supported them.

We don't support them in OpenCL.

[rjmccall]

Okay. This seems reasonable to me, then.

[keryell]

In D61304#1485814, @Anastasia wrote:

In D61304#1485125, @rjmccall wrote:

Presumably a similar rule would apply to thread-locals if you supported them.

We don't support them in OpenCL.

But this is also about OpenCL extensions here anyway...
Is thread-local not somewhat equivalent to work-item local, i.e. __private?
But I am unsure we want to really handle this, while it is already an issue in the discussion about execution contexts in ISO C++... :-)

cfe/trunk/lib/Sema/SemaType.cpp

bool IsFuncReturnType =
       D.getTypeObject(ChunkIndex - 1).Kind == DeclaratorChunk::Function;
   bool IsFuncType =
       ChunkIndex < D.getNumTypeObjects() &&
       D.getTypeObject(ChunkIndex).Kind == DeclaratorChunk::Function;
   if ( // Do not deduce addr space for function return type and function type,
        // otherwise it will fail some sema check.
       IsFuncReturnType || IsFuncType ||
       // Do not deduce addr space for member types of struct, except the pointee
-      // type of a pointer member type.
-      (D.getContext() == DeclaratorContext::MemberContext && !IsPointee) ||
+      // type of a pointer member type or static data members.
+      (D.getContext() == DeclaratorContext::MemberContext &&
+       (!IsPointee &&
+        D.getDeclSpec().getStorageClassSpec() != DeclSpec::SCS_static)) ||
       // Do not deduce addr space for types used to define a typedef and the
       // typedef itself, except the pointee type of a pointer type which is used
       // to define the typedef.
       (D.getDeclSpec().getStorageClassSpec() == DeclSpec::SCS_typedef &&
        !IsPointee) ||
       // Do not deduce addr space of the void type, e.g. in f(void), otherwise
       // it will fail some sema check.
       (T->isVoidType() && !IsPointee) ||

cfe/trunk/test/SemaOpenCLCXX/address-space-deduction.cl

+//RUN: %clang_cc1 %s -cl-std=c++ -pedantic -ast-dump -verify
+
+//expected-no-diagnostics
+
+//CHECK: |-VarDecl  foo {{.*}} 'const __global int' constexpr cinit
+constexpr int foo = 0;
+
+class c {
+public:
+  //CHECK: `-VarDecl {{.*}} foo2 'const __global int' static constexpr cinit
+  static constexpr int foo2 = 0;
+};