Page MenuHomePhabricator

keryell (Ronan Keryell)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 10 2013, 11:30 AM (347 w, 6 d)

Recent Activity

Yesterday

keryell added inline comments to D71016: [SYCL] Implement OpenCL kernel function generation.
Tue, Dec 10, 6:09 PM · Restricted Project

Jul 9 2019

keryell added a comment to D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode.

Good improvement!

Jul 9 2019, 1:21 PM · Restricted Project

Jun 19 2019

keryell added inline comments to D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.
Jun 19 2019, 6:58 PM · Restricted Project

May 30 2019

vladimirlaz <vladimir.lazarev@intel.com> committed rG4e38c234e305: [SYCL] Fix some typos (authored by keryell).
[SYCL] Fix some typos
May 30 2019, 7:57 AM

May 7 2019

keryell added a comment to D61506: [OpenCL] Switch to C++17.

Per the OpenCL C++ 1.0 specification, section 2:

The OpenCL C++ programming language is based on the ISO/IEC JTC1 SC22 WG21 N 3690 language specification (a.k.a. C++14 specification).

I think it would be reasonable to permit changing the base C++ standard in OpenCL C++ mode

May 7 2019, 12:33 PM · Restricted Project

May 3 2019

keryell added inline comments to D61506: [OpenCL] Switch to C++17.
May 3 2019, 2:34 PM · Restricted Project

May 1 2019

keryell added a comment to D61304: [OpenCL][PR41609] Deduce static data members to __global addr space.

Presumably a similar rule would apply to thread-locals if you supported them.

We don't support them in OpenCL.

May 1 2019, 7:37 PM · Restricted Project

Apr 18 2019

keryell added a comment to D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.
Apr 18 2019, 9:03 PM · Restricted Project

Apr 17 2019

keryell added a comment to D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.
Apr 17 2019, 8:30 AM · Restricted Project
keryell added a comment to D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.

It would be better to rename clang/test/SemaSYCL/device-attrubutes.cpp to clang/test/SemaSYCL/device-attributes.cpp

Apr 17 2019, 8:12 AM · Restricted Project

Apr 15 2019

keryell accepted D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.
Apr 15 2019, 5:57 PM · Restricted Project

Apr 9 2019

keryell added a comment to D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.

While we are thinking about recycling some attributes across languages, we have to think about the fact that real applications are often made from various languages, such as SYCL + OpenMP 5 or whatever.
It would be nice not to forbid such a combination inside the same TU by design.

Apr 9 2019, 3:35 PM · Restricted Project

Mar 23 2019

keryell added a comment to D59603: [PR40707][PR41011][OpenCL] Allow addr space spelling without double underscore in C++ mode.

Updated test to use root namespace (commented by Ronan).

Mar 23 2019, 11:51 AM · Restricted Project

Mar 20 2019

keryell added a comment to D59603: [PR40707][PR41011][OpenCL] Allow addr space spelling without double underscore in C++ mode.

I was a little bit worried about

Mar 20 2019, 11:47 AM · Restricted Project

Feb 15 2019

keryell added a comment to D58179: [OpenCL][PR40707] Allow OpenCL C types in C++ mode.

LGTM.

Feb 15 2019, 9:01 AM

Feb 5 2019

keryell accepted D57768: [SYCL] Add clang front-end option to enable SYCL device compilation flow..

That looks good. Thanks.

Feb 5 2019, 11:03 AM · Restricted Project

Nov 2 2018

keryell added a comment to D53705: [OpenCL] Postpone PSV address space diagnostic.
Nov 2 2018, 12:58 PM · Restricted Project

Nov 1 2018

keryell added a comment to D53705: [OpenCL] Postpone PSV address space diagnostic.
Nov 1 2018, 3:27 PM · Restricted Project
keryell added a comment to D53705: [OpenCL] Postpone PSV address space diagnostic.
Nov 1 2018, 10:55 AM · Restricted Project

Oct 30 2018

keryell added a comment to D53705: [OpenCL] Postpone PSV address space diagnostic.

I don't suppose there's any chance you can just tell Khronos to fix their stuff. It's a little funny to be more conservative about keywords in C++ when the C++ committee is actually much more aggressive about adding keywords in the non-reserved space than C is.

Oct 30 2018, 7:43 PM · Restricted Project
keryell added a comment to D53705: [OpenCL] Postpone PSV address space diagnostic.

We could submit to the standard an OpenCL C++ extension to accept the OpenCL C syntax...

Oct 30 2018, 7:31 PM · Restricted Project

Nov 19 2016

keryell added a comment to D26735: [OpenCL] Disable && (address of label) GNU extension for OpenCL.

+1
Please do not remove anything, since it may be useful in some contexts.

Nov 19 2016, 8:23 AM

Jan 12 2016

keryell added inline comments to D15914: [OpenCL] Pipe builtin functions.
Jan 12 2016, 11:52 AM

Feb 15 2015

keryell added a comment to D7647: OpenCL: Accept -cl-strict-aliasing.

Typo

Feb 15 2015, 9:57 AM