Page MenuHomePhabricator

kpet (Kévin Petit)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 12 2019, 2:29 AM (26 w, 3 d)

Recent Activity

Fri, Oct 4

kpet added a comment to D68388: [PR41008][OpenCL] Support restrict keyword in C++ mode.

Something I should probably have explained in the commit message is that the functionality provided by restrict is already present in C++, where it is already exposed using different keywords. If you look at clang/include/clang/Basic/TokenKinds.def, there are __restrict__ and __restrict aliases that end up producing tok::kw_restrict. The only thing this patch does is enabling the restrict keyword in C++ for OpenCL for compatibility with OpenCL C (see more on that on the bug). I don't expect any special handling will be required since the functionality is already supported both in C++ and OpenCL C.

Fri, Oct 4, 3:55 AM · Restricted Project

Thu, Oct 3

kpet added a comment to D68388: [PR41008][OpenCL] Support restrict keyword in C++ mode.

There doesn't seem to be a test for this (enabling restrict in C++ doesn't make any existing test fail). I couldn't find any test checking that OpenCL or C++/OpenCL keywords generally aren't enabled in C or C++. Doing this generically would essentially equate to writing unit tests for getKeywordStatus.

Thu, Oct 3, 8:22 AM · Restricted Project
kpet created D68388: [PR41008][OpenCL] Support restrict keyword in C++ mode.
Thu, Oct 3, 6:20 AM · Restricted Project

Sep 11 2019

kpet committed rL371609: Request commit access for kpet.
Request commit access for kpet
Sep 11 2019, 4:19 AM

Jul 24 2019

kpet accepted D65102: [OpenCL] Rename lang mode flag for C++ mode.
Jul 24 2019, 3:53 AM · Restricted Project

Jul 23 2019

kpet added a comment to D65102: [OpenCL] Rename lang mode flag for C++ mode.

Hmm, maybe we need to make sure that one of the tests is using a C++ feature and building with CLC++. This would have caught the mistake.

Jul 23 2019, 9:35 AM · Restricted Project
kpet added a comment to D65102: [OpenCL] Rename lang mode flag for C++ mode.

Thanks for doing this!

Jul 23 2019, 3:10 AM · Restricted Project

Jul 17 2019

kpet accepted D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode.

Would it be ok if I fix those in a separate commit? I would really like to commit the core part before the release branch is taken.

Jul 17 2019, 8:36 AM · Restricted Project
kpet requested changes to D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode.

Very useful to have all of this documented! Thanks!

Jul 17 2019, 6:52 AM · Restricted Project

Jun 18 2019

kpet added a comment to D62722: [Driver] Simplify Assemble and Backend action collapsing.

Friendly ping :).

Jun 18 2019, 5:14 AM · Restricted Project

May 31 2019

kpet updated the summary of D62722: [Driver] Simplify Assemble and Backend action collapsing.
May 31 2019, 2:09 AM · Restricted Project
kpet created D62722: [Driver] Simplify Assemble and Backend action collapsing.
May 31 2019, 2:08 AM · Restricted Project

May 24 2019

kpet closed D62377: [OpenCL] Add support for the cl_arm_integer_dot_product extensions.

Committed as r361641.

May 24 2019, 9:06 AM · Restricted Project
kpet committed rC361641: [OpenCL] Add support for the cl_arm_integer_dot_product extensions.
[OpenCL] Add support for the cl_arm_integer_dot_product extensions
May 24 2019, 7:51 AM
kpet committed rL361641: [OpenCL] Add support for the cl_arm_integer_dot_product extensions.
[OpenCL] Add support for the cl_arm_integer_dot_product extensions
May 24 2019, 7:51 AM
kpet added a comment to D62377: [OpenCL] Add support for the cl_arm_integer_dot_product extensions.

Yes, indeed :).

May 24 2019, 4:49 AM · Restricted Project
kpet updated the summary of D62377: [OpenCL] Add support for the cl_arm_integer_dot_product extensions.
May 24 2019, 4:45 AM · Restricted Project
kpet created D62377: [OpenCL] Add support for the cl_arm_integer_dot_product extensions.
May 24 2019, 3:26 AM · Restricted Project

May 15 2019

kpet committed rL360783: Test commit.
Test commit
May 15 2019, 9:37 AM
kpet committed rC360783: Test commit.
Test commit
May 15 2019, 9:37 AM

May 9 2019

kpet accepted D61488: [OpenCL] Make global ctor init function a kernel.

The comments could use a bit more polishing but nothing that justifies making another iteration IMHO. LGTM!

May 9 2019, 2:32 AM · Restricted Project

May 8 2019

kpet accepted D61506: [OpenCL] Switch to C++17.

LGTM.

May 8 2019, 5:28 AM · Restricted Project

May 7 2019

kpet created D61639: Add Triple::isSPIR() to simplify code.
May 7 2019, 3:54 AM · Restricted Project, Restricted Project

May 3 2019

kpet added inline comments to D61506: [OpenCL] Switch to C++17.
May 3 2019, 7:39 AM · Restricted Project
kpet added inline comments to D61488: [OpenCL] Make global ctor init function a kernel.
May 3 2019, 7:37 AM · Restricted Project

May 2 2019

kpet updated the diff for D61319: [PR41674] [OpenCL] Fix initialisation of this via pointer.

Clean up the tests.

May 2 2019, 4:49 AM · Restricted Project
kpet added a comment to D61319: [PR41674] [OpenCL] Fix initialisation of this via pointer.

Most of these are pre-existing issues with the tests but I agree they're worth fixing. I'll update the tests.

May 2 2019, 4:35 AM · Restricted Project

May 1 2019

kpet updated the diff for D61319: [PR41674] [OpenCL] Fix initialisation of this via pointer.

Replaced the AST dump test with an IR test.

May 1 2019, 12:50 PM · Restricted Project
kpet added a comment to D61319: [PR41674] [OpenCL] Fix initialisation of this via pointer.

Ok, I'll replace the test with an IR-level test.

May 1 2019, 10:22 AM · Restricted Project

Apr 30 2019

kpet created D61319: [PR41674] [OpenCL] Fix initialisation of this via pointer.
Apr 30 2019, 9:33 AM · Restricted Project

Apr 23 2019

kpet added a comment to D60602: [InferAddressSpaces] Add AS parameter to the pass factory.

The implementation of getFlatAddressSpace in the AMDGPU backend does a bit more than just return a constant. This logic would need to be duplicated or the TTI called from their pass factory which would be the first use. TBH, I'm not too worried about the change to the factory breaking. This will be used in an out-of-tree project that tracks llvm fairly closely. If this breaks, I'll propose a change to exercise this from some in-tree code.

Apr 23 2019, 11:05 PM · Restricted Project

Apr 18 2019

kpet added a comment to D60602: [InferAddressSpaces] Add AS parameter to the pass factory.

But would it be possible to extract an .ll file generated from C++ (may be with some amendments) and run opt with the pass enabled?

Apr 18 2019, 6:50 AM · Restricted Project
kpet added a comment to D60602: [InferAddressSpaces] Add AS parameter to the pass factory.

This doesn't fix anything broken in LLVM but I did check that it didn't break any of the existing tests either :).

Apr 18 2019, 6:29 AM · Restricted Project
kpet added a comment to D60602: [InferAddressSpaces] Add AS parameter to the pass factory.

The pass is used by the AMDGPU and NVPTX backends. All their tests are passing with this change.

Apr 18 2019, 5:05 AM · Restricted Project

Apr 17 2019

kpet updated the diff for D60602: [InferAddressSpaces] Add AS parameter to the pass factory.

Address review comments.

Apr 17 2019, 6:32 AM · Restricted Project
kpet added inline comments to D60602: [InferAddressSpaces] Add AS parameter to the pass factory.
Apr 17 2019, 6:20 AM · Restricted Project
kpet added a comment to D60602: [InferAddressSpaces] Add AS parameter to the pass factory.

@arsenm Thanks for the review.

Apr 17 2019, 6:13 AM · Restricted Project
kpet added a reviewer for D60602: [InferAddressSpaces] Add AS parameter to the pass factory: joey.
Apr 17 2019, 2:42 AM · Restricted Project

Apr 12 2019

kpet created D60602: [InferAddressSpaces] Add AS parameter to the pass factory.
Apr 12 2019, 2:41 AM · Restricted Project