This is an archive of the discontinued LLVM Phabricator instance.

Support overaligned types in `aligned_storage`.
ClosedPublic

Authored by EricWF on Apr 30 2019, 3:40 AM.

Details

Summary

The current implementation of aligned storage was written before we had alignas, so it used a list of builtin types to force the alignment. But this doesn't work overaligned requests.

This patch adds a fallback case supporting over-alignment. It only affects case that were previously ill-formed.

Diff Detail

Repository
rL LLVM

Event Timeline

EricWF created this revision.Apr 30 2019, 3:40 AM
EricWF added a reviewer: dlj.Apr 30 2019, 3:40 AM
mclow.lists accepted this revision.Apr 30 2019, 8:21 AM
mclow.lists added a subscriber: mclow.lists.

LGTM.

This revision is now accepted and ready to land.Apr 30 2019, 8:21 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 30 2019, 11:42 AM