Page MenuHomePhabricator

[clang-format] Fix bug in block comment reflow that joins * and /
ClosedPublic

Authored by owenpan on Apr 29 2019, 1:02 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

owenpan created this revision.Apr 29 2019, 1:02 PM

Thanks for the patch, is this case only limited to *<tab>

@MyDeveloperDay In theory, any whitespace character other than a blank might trigger the bug, but in practice, we only need to handle the tab, IMO.

owenpan planned changes to this revision.May 2 2019, 1:30 AM

There are some corner cases this patch doesn't cover.

owenpan updated this revision to Diff 197720.May 2 2019, 2:10 AM

Updated the patch to cover all scenarios in which the bug might be triggered.

This revision is now accepted and ready to land.May 3 2019, 10:17 AM
owenpan updated this revision to Diff 198057.May 3 2019, 4:11 PM

Updated the test cases to make them precise and more varied.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 3 2019, 4:13 PM