This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] gfx1010 VOP3 and VOP3P implementation
ClosedPublic

Authored by rampitec on Apr 26 2019, 10:40 AM.

Diff Detail

Event Timeline

rampitec created this revision.Apr 26 2019, 10:40 AM
kzhuravl accepted this revision.Apr 26 2019, 10:47 AM

LGTM

lib/Target/AMDGPU/VOP3Instructions.td
771

IIRC it is already fixed.

This revision is now accepted and ready to land.Apr 26 2019, 10:47 AM
kzhuravl added inline comments.Apr 26 2019, 10:49 AM
lib/Target/AMDGPU/VOP3Instructions.td
446–450

Yes, it is fixed.

771

Comment should either be removed before submission or in a follow up change. Thanks.

rampitec marked an inline comment as done.Apr 26 2019, 10:53 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2019, 10:54 AM