This is an archive of the discontinued LLVM Phabricator instance.

[cmake] Fix error message in simulated VS version check
ClosedPublic

Authored by russell.gallop on Apr 26 2019, 7:25 AM.

Details

Summary

[cmake] Fix error message on simulated VS version check

For clang-cl self hosts in VS2015 environment this was reporting: "Host
Clang must have at least -fms-compatibility-version=19.00.24213.1, your
version is 9.0.0".

This check fires as CMake detects the simulated environment as _MSC_VER
1900, which is truncated. This makes it less than the required
19.00.24213.1.

Diff Detail

Event Timeline

russell.gallop created this revision.Apr 26 2019, 7:25 AM
smeenai accepted this revision.Apr 29 2019, 4:34 PM
smeenai added a subscriber: smeenai.

LGTM with the indent fixed.

llvm/cmake/modules/CheckCompilerVersion.cmake
53

Should be a 2 space indent here.

This revision is now accepted and ready to land.Apr 29 2019, 4:34 PM
This revision was automatically updated to reflect the committed changes.