Page MenuHomePhabricator

Kill modify-python-lldb.py
ClosedPublic

Authored by labath on Apr 23 2019, 4:44 AM.

Details

Summary

After the last round of cleanups, this script was almost a no-op. The
only piece of functionality that remained was the one which tried to
make the swig-generated function signatures more pythonic.

The "tried" part is important here, as it wasn't doing a really good job
and the end result was not valid python nor c (e.g.,
SetExecutable(SBAttachInfo self, str const * path)).

Doing these transformations another way is not possible, as these
signatures are generated by swig, and not present in source. However,
given that this is the only reason why we need a swig post-process step,
and that the current implementation is pretty sub-optimal, I propose we
simply abandon the the signature fixup idea, and choose to simplify our
build process instead.

Diff Detail

Repository
rL LLVM

Event Timeline

labath created this revision.Apr 23 2019, 4:44 AM

Can you post a diff of things before and after? Hard to tell what we are opting out of just by seeing this patch

Sure. This is the diff:

.

jingham accepted this revision.Apr 23 2019, 11:02 AM

Since this just changes how we fix up comments for the generated functions in lldb.py, I can't see any harm in removing it. It is clearly showing you a C-view of the function, so char -> str doesn't seem terribly helpful to me.

This revision is now accepted and ready to land.Apr 23 2019, 11:02 AM
clayborg accepted this revision.Apr 23 2019, 11:37 AM

Thanks for the diff! LGTM

amccarth accepted this revision.Apr 23 2019, 3:26 PM
Closed by commit rL359092: Kill modify-python-lldb.py (authored by labath, committed by ). · Explain WhyApr 24 2019, 6:21 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 24 2019, 6:21 AM