This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Fix R_WASM_FUNCTION_OFFSET_I32 relocation warnings
ClosedPublic

Authored by sbc100 on Apr 19 2019, 4:48 PM.

Details

Summary

We were incorrectly used the symbol table version of the function rather
than the object-local version when checking the existing relocation
value.

This was causing erroneous warnings for comat symbols defined in
multiple object.s

Fixes: #40503

Diff Detail

Repository
rL LLVM

Event Timeline

sbc100 created this revision.Apr 19 2019, 4:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2019, 4:48 PM
kripken accepted this revision.Apr 19 2019, 5:23 PM

Not an expert on this code but it looks right to me.

This revision is now accepted and ready to land.Apr 19 2019, 5:23 PM
This revision was automatically updated to reflect the committed changes.