Page MenuHomePhabricator

[CMake] Replace the sanitizer support in runtimes build with multilib
ClosedPublic

Authored by phosek on Apr 19 2019, 4:25 PM.

Details

Summary

This is a more generic solution; while the sanitizer support can be used
only for sanitizer instrumented builds, the multilib support can be used
to build other variants such as noexcept which is what we would like to use
in Fuchsia.

The name CMake target name uses the target name, same as for the regular
runtimes build and the name of the multilib, concatenated with '+'. The
libraries are installed in a subdirectory named after the multilib.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.Apr 19 2019, 4:25 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 19 2019, 4:25 PM
phosek updated this revision to Diff 195934.Apr 19 2019, 4:26 PM
beanz accepted this revision.Apr 22 2019, 1:20 PM

I really like this. Using + to add variants seems much widely useful.

This revision is now accepted and ready to land.Apr 22 2019, 1:20 PM
This revision was automatically updated to reflect the committed changes.