[HWASan] Added no-FP unit test for register dump.

[hctim]

Summary

Unit test for D60798.

[pcc]

compiler-rt/test/hwasan/TestCases/register-dump-no-fp.cc

44 ↗

(On Diff #195491)

Maybe don't try to match this part since you're already matching for them in register-dump-read.c.

[eugenis]

compiler-rt/test/hwasan/TestCases/register-dump-no-fp.cc

2 ↗

(On Diff #195491)

You are testing the case when f() does NOT have a frame pointer - why add these flags?

44 ↗

(On Diff #195491)

Right. Just test that main() is in the stack trace, nothing more.

[hctim]

Address @pcc and @eugenis comments.

compiler-rt/test/hwasan/TestCases/register-dump-no-fp.cc

2 ↗

(On Diff #195491)

Is this in reference to the -ffixed-* flags? Assuming it is, have removed.

[eugenis]

compiler-rt/test/hwasan/TestCases/register-dump-no-fp.cc

2 ↗

(On Diff #195491)

No, I meant *no-omit* flags. You are testing the case then f() does NOT have a frame pointer. These flags ADD frame pointer to all functions. The test case only works because they fail to apply to f() for unknown reason.

[hctim]

/s/no-omit/omit

compiler-rt/test/hwasan/TestCases/register-dump-no-fp.cc

2 ↗

(On Diff #195491)

Ack. Missed the double negative on the flag :)

[eugenis]

LGTM

[hctim]

Fyi - I accidentally committed using the wrong branch, just means that all of my local commits are going up one-by-one.

See d43dc9e78b2cd9ba7c578f25e47c54cf532c5ef4, 371f43a6c0f542eb20150c90341aaed09b78fc92, 371f43a6c0f542eb20150c90341aaed09b78fc92, 026781c96200c9afad31847a5f3cced947520604.

The final committed diff from all of these patches is (as was reviewed):

--- /dev/null
+++ b/compiler-rt/test/hwasan/TestCases/register-dump-no-fp.cc
@@ -0,0 +1,28 @@
+// RUN: %clangxx_hwasan -fomit-frame-pointer -momit-leaf-frame-pointer \
+// RUN:   -O0 %s -o %t && not %run %t 2>&1 | FileCheck %s --check-prefixes=CHECK
+// RUN: %clangxx_hwasan -fomit-frame-pointer -momit-leaf-frame-pointer \
+// RUN:   -O1 %s -o %t && not %run %t 2>&1 | FileCheck %s --check-prefixes=CHECK
+// RUN: %clangxx_hwasan -fomit-frame-pointer -momit-leaf-frame-pointer \
+// RUN:   -O2 %s -o %t && not %run %t 2>&1 | FileCheck %s --check-prefixes=CHECK
+// RUN: %clangxx_hwasan -fomit-frame-pointer -momit-leaf-frame-pointer \
+// RUN:   -O3 %s -o %t && not %run %t 2>&1 | FileCheck %s --check-prefixes=CHECK
+
+// This test ensures that the CFA is implemented properly for slow
+// (non-frame-pointer) unwinding.
+#include <sanitizer/hwasan_interface.h>
+#include <stdio.h>
+#include <stdlib.h>
+
+__attribute__((noinline)) void f(int *p) { *p = 3; }
+
+// CHECK: ERROR: HWAddressSanitizer:
+// CHECK: #0 {{.*}} in f(int*) {{.*}}register-dump-no-fp.cc:[[@LINE-3]]
+
+int main() {
+  __hwasan_enable_allocator_tagging();
+
+  int *volatile a = new int;
+  a = (int *)__hwasan_tag_pointer(a, 0);
+  f(a);
+  // CHECK: #1 {{.*}} in main {{.*}}register-dump-no-fp.cc:[[@LINE-1]]
+}

compiler-rt/trunk/test/hwasan/TestCases/register-dump-no-fp.cc

-// RUN: %clangxx_hwasan -ffixed-x10 -ffixed-x20 -ffixed-x27 -fno-omit-frame-pointer \
-// RUN:   -mno-omit-leaf-frame-pointer -O0 %s -o %t && not %run %t 2>&1 | \
-// RUN:   FileCheck %s --check-prefixes=CHECK
-// RUN: %clangxx_hwasan -ffixed-x10 -ffixed-x20 -ffixed-x27 -fno-omit-frame-pointer \
-// RUN:   -mno-omit-leaf-frame-pointer -O1 %s -o %t && not %run %t 2>&1 | \
-// RUN:   FileCheck %s --check-prefixes=CHECK
-// RUN: %clangxx_hwasan -ffixed-x10 -ffixed-x20 -ffixed-x27 -fno-omit-frame-pointer \
-// RUN:   -mno-omit-leaf-frame-pointer -O2 %s -o %t && not %run %t 2>&1 | \
-// RUN:   FileCheck %s --check-prefixes=CHECK
-// RUN: %clangxx_hwasan -ffixed-x10 -ffixed-x20 -ffixed-x27 -fno-omit-frame-pointer \
-// RUN:   -mno-omit-leaf-frame-pointer -O3 %s -o %t && not %run %t 2>&1 | \
-// RUN:   FileCheck %s --check-prefixes=CHECK
+// RUN: %clangxx_hwasan -ffixed-x10 -ffixed-x20 -ffixed-x27 \
+// RUN:   -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -O0 %s -o %t && \
+// RUN:   not %run %t 2>&1 | FileCheck %s --check-prefixes=CHECK
+// RUN: %clangxx_hwasan -ffixed-x10 -ffixed-x20 -ffixed-x27 \
+// RUN:   -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -O1 %s -o %t && \
+// RUN:   not %run %t 2>&1 | FileCheck %s --check-prefixes=CHECK
+// RUN: %clangxx_hwasan -ffixed-x10 -ffixed-x20 -ffixed-x27 \
+// RUN:   -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -O2 %s -o %t && \
+// RUN:   not %run %t 2>&1 | FileCheck %s --check-prefixes=CHECK
+// RUN: %clangxx_hwasan -ffixed-x10 -ffixed-x20 -ffixed-x27 \
+// RUN:   -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -O3 %s -o %t && \
+// RUN:   not %run %t 2>&1 | FileCheck %s --check-prefixes=CHECK
 // REQUIRES: aarch64-target-arch
 #include <stdlib.h>
 #include <stdio.h>
 #include <sanitizer/hwasan_interface.h>
 
 __attribute__((noinline)) void f(int *p) { *p = 3; }
 
 // CHECK: ERROR: HWAddressSanitizer: