This is an archive of the discontinued LLVM Phabricator instance.

[builtins] Add __cmpsf2 for ARM version of comparesf2
ClosedPublic

Authored by kongyi on Apr 16 2019, 4:51 PM.

Reviewers

srhines
pirama

Commits

Summary

The generic version of comparesf2 defines __cmpsf2 alias for libgcc compatibility, but the ARM overlay is missing the alias.

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 16 2019, 4:51 PM

Thanks for finding this. Note that this is the exact code in comparesf2.c.

This revision is now accepted and ready to land.Apr 16 2019, 6:02 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

compiler-rt/

trunk/

lib/

builtins/

arm/

5 lines

Show First 20 Lines • Show All 169 Lines • ▼ Show 20 Lines	#else
JMP(lr)		JMP(lr)
#endif		#endif
END_COMPILERRT_FUNCTION(__eqsf2)		END_COMPILERRT_FUNCTION(__eqsf2)

DEFINE_COMPILERRT_FUNCTION_ALIAS(__lesf2, __eqsf2)		DEFINE_COMPILERRT_FUNCTION_ALIAS(__lesf2, __eqsf2)
DEFINE_COMPILERRT_FUNCTION_ALIAS(__ltsf2, __eqsf2)		DEFINE_COMPILERRT_FUNCTION_ALIAS(__ltsf2, __eqsf2)
DEFINE_COMPILERRT_FUNCTION_ALIAS(__nesf2, __eqsf2)		DEFINE_COMPILERRT_FUNCTION_ALIAS(__nesf2, __eqsf2)

		#if defined(__ELF__)
		// Alias for libgcc compatibility
		DEFINE_COMPILERRT_FUNCTION_ALIAS(__cmpsf2, __lesf2)
		#endif

@ int __gtsf2(float a, float b)		@ int __gtsf2(float a, float b)

.p2align 2		.p2align 2
DEFINE_COMPILERRT_FUNCTION(__gtsf2)		DEFINE_COMPILERRT_FUNCTION(__gtsf2)
// Identical to the preceding except in that we return -1 for NaN values.		// Identical to the preceding except in that we return -1 for NaN values.
// Given that the two paths share so much code, one might be tempted to		// Given that the two paths share so much code, one might be tempted to
// unify them; however, the extra code needed to do so makes the code size		// unify them; however, the extra code needed to do so makes the code size
// to performance tradeoff very hard to justify for such small functions.		// to performance tradeoff very hard to justify for such small functions.
▲ Show 20 Lines • Show All 110 Lines • Show Last 20 Lines