Page MenuHomePhabricator

Fixed memory leak reported in https://bugs.llvm.org/show_bug.cgi?id=41494
ClosedPublic

Authored by AndreyChurbanov on Apr 15 2019, 11:50 AM.

Details

Summary

Might be a bit too verbose (not sure if we need to check that the number of threads reduced to 0), but it fixes the memory leak(s) for me. Multiple leaks were possible in case of multiple foreign threads registered into the library.

Diff Detail

Repository
rL LLVM

Event Timeline

lebedev.ri accepted this revision.Apr 15 2019, 12:06 PM

Thank you for the fix!
I can't really comment on the correctness of the fix, but i can confirm that it does indeed fix the leak i was seeing.

This revision is now accepted and ready to land.Apr 15 2019, 12:06 PM
Closed by commit rL358572: Fixed memory leak reported in Bugzilla: (authored by achurbanov, committed by ). · Explain WhyApr 17 2019, 3:42 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 17 2019, 3:42 AM