This is an archive of the discontinued LLVM Phabricator instance.

[CallSite removal] move InlineCost to CallBase usage
ClosedPublic

Authored by fedor.sergeev on Apr 12 2019, 2:59 PM.

Details

Summary

Converting InlineCost interface and its internals into CallBase usage.
Inliners themselves are still not converted.

Event Timeline

fedor.sergeev created this revision.Apr 12 2019, 2:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2019, 2:59 PM
nhaehnle removed a subscriber: nhaehnle.Apr 17 2019, 7:28 AM
reames accepted this revision.Apr 22 2019, 9:25 AM

LGTM

llvm/lib/Analysis/InlineCost.cpp
2095

Doesn't look like you need the cast to CallInst here.

This revision is now accepted and ready to land.Apr 22 2019, 9:25 AM
fedor.sergeev marked 2 inline comments as done.Apr 23 2019, 5:02 AM
fedor.sergeev added inline comments.
llvm/lib/Analysis/InlineCost.cpp
2095

canReturnTwice is CallInst member, it is not available for CallBase.

This revision was automatically updated to reflect the committed changes.
fedor.sergeev marked an inline comment as done.