Page MenuHomePhabricator

[clang] Aligned allocation is actually supported in macosx 10.13
ClosedPublic

Authored by ldionne on Apr 12 2019, 11:17 AM.

Details

Summary

In r350649, I changed aligned allocation from being available starting
in macosx10.13 to macosx10.14. However, aligned allocation is indeed
available starting with macosx10.13, my investigation had been based
on the wrong libc++abi dylib.

This means that Clang before the fix will be more stringent when it
comes to aligned allocation -- it will not allow it when back-deploying
to macosx 10.13, when it would actually be safe to do so.

Note that a companion change will be coming to fix the libc++ tests.

Diff Detail

Repository
rL LLVM

Event Timeline

ldionne created this revision.Apr 12 2019, 11:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2019, 11:17 AM
This revision is now accepted and ready to land.Apr 12 2019, 4:21 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2019, 7:16 AM

Just as a note to someone that might get here through CI failures: I expect this will break back-deployment CIs for libc++ that use recent Clangs (because the XFAILs in libc++ won't be correct anymore). I have a patch ready to address that but I want to see exactly how the CIs fail before I apply the patch.

Reverted in r358437 because of unforeseen CI failures. The failures I was expecting are in libc++, not in compiler-rt. I'll investigate locally and re-apply.