Page MenuHomePhabricator

[Transforms][ASan] Move findAllocaForValue() to Utils/Local.cpp. NFC
ClosedPublic

Authored by glider on Apr 12 2019, 7:17 AM.

Details

Summary

Factor out findAllocaForValue() from ASan so that we can use it in
MSan to handle lifetime intrinsics.

Diff Detail

Repository
rL LLVM

Event Timeline

glider created this revision.Apr 12 2019, 7:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2019, 7:17 AM
eugenis accepted this revision.Apr 12 2019, 1:05 PM

This is very similar to GetUnderlyingObject, but it also handles PHIs, has a cache, but does not do InstructionSimplify and does not have a lookup limit.
It would be nice to merge the two.

LGTM

This revision is now accepted and ready to land.Apr 12 2019, 1:05 PM
This revision was automatically updated to reflect the committed changes.

This is very similar to GetUnderlyingObject, but it also handles PHIs, has a cache, but does not do InstructionSimplify and does not have a lookup limit.
It would be nice to merge the two.

Ok, noted.

LGTM