Page MenuHomePhabricator

[AArch64][GlobalISel] Enable copy elision in the pre-legalizer combine and fix a crash
ClosedPublic

Authored by aemerson on Apr 11 2019, 1:51 PM.

Details

Summary

This enables the simple copy combine that already exists in the CombinerHelper.

However, it exposed a bug in the GISelChangeObserver where it wouldn't clear a set of MIs to process, and so would end up causing a crash when deleted MIs were being added to the combiner worklist again.

Diff Detail

Event Timeline

aemerson created this revision.Apr 11 2019, 1:51 PM

Looks good to me.

This revision is now accepted and ready to land.Apr 11 2019, 1:53 PM
This revision was automatically updated to reflect the committed changes.