Page MenuHomePhabricator

Support objc_nonlazy_class attribute on Objective-C implementations
ClosedPublic

Authored by erik.pilkington on Apr 10 2019, 3:13 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptApr 10 2019, 3:13 PM

Should we have a special has_feature test to check that this attribute is allowed on implementations? We've done that in the past when expanding the set of subjects for an attribute. But that's not necessary if we haven't made this attribute part of a public Xcode release yet, because then the attribute is just understood to always apply to implementations; I can't remember when exactly this was added and what releases it's made it into.

aaron.ballman accepted this revision.Apr 11 2019, 9:08 AM

LGTM, modulo the __has_feature question.

This revision is now accepted and ready to land.Apr 11 2019, 9:08 AM

Should we have a special has_feature test to check that this attribute is allowed on implementations? We've done that in the past when expanding the set of subjects for an attribute. But that's not necessary if we haven't made this attribute part of a public Xcode release yet, because then the attribute is just understood to always apply to implementations; I can't remember when exactly this was added and what releases it's made it into.

I think we can sneak by without a __has_feature for this, D56555 isn't in LLVM 8 nor Xcode 10.2.

rjmccall accepted this revision.Apr 11 2019, 10:29 AM

Great, SGTM.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 11 2019, 10:55 AM