This is an archive of the discontinued LLVM Phabricator instance.

[builtins] Use single line C++/C99 comment style
ClosedPublic

Authored by phosek on Apr 5 2019, 6:11 PM.

Diff Detail

Event Timeline

phosek created this revision.Apr 5 2019, 6:11 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, Restricted Project, mstorsjo and 6 others. · View Herald Transcript
jfb added a comment.Apr 6 2019, 2:37 PM

Why? This seems like needless churn and is kinda annoying for mergebots.

jfb added a comment.Apr 8 2019, 9:21 AM

Thanks @echristo for pointing out "[RFC] compiler-rt builtins cleanup and refactoring". You do intend to modify this code, so a reformat ahead of time is then fine. Please link to the RFC in the commit message.

echristo accepted this revision.Apr 8 2019, 10:04 AM

LGTM.

This revision is now accepted and ready to land.Apr 8 2019, 10:04 AM
This revision was automatically updated to reflect the committed changes.