This is an archive of the discontinued LLVM Phabricator instance.

GlobalISel: Fix invoke lowering creating invalid type registers
ClosedPublic

Authored by arsenm on Apr 5 2019, 2:10 PM.

Details

Summary

Unlike the call handling, this wasn't checking for void results and
creating a register with the invalid LLT.

Diff Detail

Event Timeline

arsenm created this revision.Apr 5 2019, 2:10 PM
arsenm edited the summary of this revision. (Show Details)Apr 5 2019, 2:10 PM

Is there a reasonably sized test?

arsenm added a comment.Apr 5 2019, 2:59 PM

Is there a reasonably sized test?

I don’t think this actually broke anything other than wasting a register. The assert I added is hit for at least one invoke in the current tests

aemerson accepted this revision.Apr 5 2019, 3:14 PM
This revision is now accepted and ready to land.Apr 5 2019, 3:14 PM
arsenm closed this revision.Apr 10 2019, 10:26 AM

r358110