This is an archive of the discontinued LLVM Phabricator instance.

ELF: De-template SharedFile. NFCI.
ClosedPublic

Authored by pcc on Apr 4 2019, 9:38 PM.

Event Timeline

pcc created this revision.Apr 4 2019, 9:38 PM
Herald added a project: Restricted Project. · View Herald Transcript
ruiu added a comment.Apr 4 2019, 10:53 PM

Nice!

lld/ELF/InputFiles.cpp
1020–1021

Even though this function is not logically complicated, I'd split it into smaller pieces just because it's a bit too long.

pcc updated this revision to Diff 193964.Apr 5 2019, 1:51 PM
pcc marked 2 inline comments as done.
  • Split out code into functions
pcc added inline comments.Apr 5 2019, 1:52 PM
lld/ELF/InputFiles.cpp
1020–1021

Okay, I split out a couple of functions that don't need a lot of state from the parse() function. It seemed awkward to split out more than that because of the amount of state that would need to be passed in, but maybe you can give it a try.

ruiu accepted this revision.Apr 7 2019, 11:31 PM

LGTM

This revision is now accepted and ready to land.Apr 7 2019, 11:31 PM
This revision was automatically updated to reflect the committed changes.