Page MenuHomePhabricator

Add lld to the list of dependencies for the lldb_scheduler
ClosedPublic

Authored by stella.stamenova on Apr 3 2019, 1:10 PM.

Details

Summary

lld is currently not on the list of dependencies for the lldb_scheduler, so lld commits are not added to the blamelist for lldb builds

Diff Detail

Repository
rL LLVM

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2019, 1:10 PM
ruiu added a subscriber: ruiu.Apr 3 2019, 5:31 PM

Does this mean a commit to lld could potentially break lldb?

Does this mean a commit to lld could potentially break lldb?

The LLDB bots currently have a dependency on LLD for the tests and commits to LLD break the bots with some frequency, but because the dependency is not listed for the lldb_scheduler, the LLD commits don't end up on the blamelist for the bots and it's a bit difficult to track down the break to LLD. This change adds LLD to the list of dependencies, so that we can see the corresponding LLD commits on the blamelist.

This revision is now accepted and ready to land.Apr 4 2019, 1:15 PM
This revision was automatically updated to reflect the committed changes.