Page MenuHomePhabricator

check-clang-tools: Actually build and run XPC test
ClosedPublic

Authored by thakis on Apr 2 2019, 5:09 AM.

Details

Summary

The CMake variable controlling if XPC code is built is called CLANGD_BUILD_XPC but three places unintentionally checked the non-existent variable CLANGD_BUILD_XPC_SUPPORT instead, which (due to being nonexistent, and due to cmake) always silently evaluated to false.

Luckily the test still seems to pass, despite never running after being added almost 3 months ago in r351280.

Diff Detail

Event Timeline

thakis created this revision.Apr 2 2019, 5:09 AM

(I noticed this while working on D60130)

erik.pilkington, could you stamp this maybe?

jkorous accepted this revision.Apr 4 2019, 1:03 PM

LGTM. Thanks for fixing this!

This revision is now accepted and ready to land.Apr 4 2019, 1:03 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2019, 1:10 PM