MemoryPhis cannot be optimized out until they are complete.
Resolves PR41254.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
- Build Status
Buildable 29774 Build 29773: arc lint + arc unit
Event Timeline
Comment Actions
Thanks for this!
lib/Analysis/MemorySSAUpdater.cpp | ||
---|---|---|
315 | Should these be removed from NonOptPhis at some point later (e.g., around line 326)? Or is that done for us elsewhere? |
lib/Analysis/MemorySSAUpdater.cpp | ||
---|---|---|
315 | I believe it's removed in fixupDefs(). |
Comment Actions
LGTM modulo one nit; thanks again!
lib/Analysis/MemorySSAUpdater.cpp | ||
---|---|---|
315 | Please add a comment to that effect here, then |
Should these be removed from NonOptPhis at some point later (e.g., around line 326)? Or is that done for us elsewhere?