This is an archive of the discontinued LLVM Phabricator instance.

Differential D59897

[DAGCombiner] Teach TokenFactor pruning to peek through lifetime nodes
ClosedPublic

Authored by niravd on Mar 27 2019, 1:10 PM.

Details

Reviewers
courbet
jyknight
Commits
rG6b741a803867: [DAGCombiner] Teach TokenFactor pruning to peek through lifetime nodes
rL357121: [DAGCombiner] Teach TokenFactor pruning to peek through lifetime nodes
Summary

Lifetime nodes were inhibiting TokenFactor simplification inhibiting chain-based optimizations.

Diff Detail

Event Timeline

niravd created this revision.Mar 27 2019, 1:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 27 2019, 1:10 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
Harbormaster completed remote builds in B29702: Diff 192503.Mar 27 2019, 1:10 PM
niravd updated this revision to Diff 192508.Mar 27 2019, 1:26 PM

Debug test also changes. h

Harbormaster completed remote builds in B29703: Diff 192508.Mar 27 2019, 1:26 PM
niravd added a subscriber: nickdesaulniers.Mar 27 2019, 1:30 PM
jyknight accepted this revision.Mar 27 2019, 1:35 PM
This revision is now accepted and ready to land.Mar 27 2019, 1:35 PM
Closed by commit rL357121: [DAGCombiner] Teach TokenFactor pruning to peek through lifetime nodes (authored by niravd). · Explain WhyMar 27 2019, 1:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
CodeGen/
SelectionDAG/
2 lines
test/
CodeGen/
X86/
6 lines

Diff 192503

llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 1,831 Lines • ▼ Show 20 Lines case ISD::EntryToken:
// another operand's search. Prevent us from marking this operand // another operand's search. Prevent us from marking this operand
// considered. // considered.
NumLeftToConsider++; NumLeftToConsider++;
break; break;
case ISD::TokenFactor: case ISD::TokenFactor:
for (const SDValue &Op : CurNode->op_values()) for (const SDValue &Op : CurNode->op_values())
AddToWorklist(i, Op.getNode(), CurOpNumber); AddToWorklist(i, Op.getNode(), CurOpNumber);
break; break;
case ISD::LIFETIME_START:
case ISD::LIFETIME_END:
case ISD::CopyFromReg: case ISD::CopyFromReg:
case ISD::CopyToReg: case ISD::CopyToReg:
AddToWorklist(i, CurNode->getOperand(0).getNode(), CurOpNumber); AddToWorklist(i, CurNode->getOperand(0).getNode(), CurOpNumber);
break; break;
default: default:
if (auto *MemNode = dyn_cast<MemSDNode>(CurNode)) if (auto *MemNode = dyn_cast<MemSDNode>(CurNode))
AddToWorklist(i, MemNode->getChain().getNode(), CurOpNumber); AddToWorklist(i, MemNode->getChain().getNode(), CurOpNumber);
break; break;
▲ Show 20 Lines • Show All 17,949 Lines • Show Last 20 Lines

llvm/test/CodeGen/X86/swap.ll

Show First 20 Lines • Show All 113 Lines • ▼ Show 20 Lines
define dso_local void @onealloc_readback_1(i8* nocapture %a, i8* nocapture %b) local_unnamed_addr { define dso_local void @onealloc_readback_1(i8* nocapture %a, i8* nocapture %b) local_unnamed_addr {
; NOAA-LABEL: onealloc_readback_1: ; NOAA-LABEL: onealloc_readback_1:
; NOAA: # %bb.0: # %entry ; NOAA: # %bb.0: # %entry
; NOAA-NEXT: vmovups (%rdi), %xmm0 ; NOAA-NEXT: vmovups (%rdi), %xmm0
; NOAA-NEXT: vmovaps %xmm0, -{{[0-9]+}}(%rsp) ; NOAA-NEXT: vmovaps %xmm0, -{{[0-9]+}}(%rsp)
; NOAA-NEXT: vmovups (%rsi), %xmm0 ; NOAA-NEXT: vmovups (%rsi), %xmm0
; NOAA-NEXT: vmovaps %xmm0, -{{[0-9]+}}(%rsp) ; NOAA-NEXT: vmovaps %xmm0, -{{[0-9]+}}(%rsp)
; NOAA-NEXT: vmovaps -{{[0-9]+}}(%rsp), %xmm0
; NOAA-NEXT: vmovups %xmm0, (%rdi) ; NOAA-NEXT: vmovups %xmm0, (%rdi)
; NOAA-NEXT: retq ; NOAA-NEXT: retq
; ;
; AA-LABEL: onealloc_readback_1: ; AA-LABEL: onealloc_readback_1:
; AA: # %bb.0: # %entry ; AA: # %bb.0: # %entry
; AA-NEXT: vmovups (%rdi), %xmm0
; AA-NEXT: vmovaps %xmm0, -{{[0-9]+}}(%rsp)
; AA-NEXT: vmovups (%rsi), %xmm0 ; AA-NEXT: vmovups (%rsi), %xmm0
; AA-NEXT: vmovaps %xmm0, -{{[0-9]+}}(%rsp) ; AA-NEXT: vmovaps %xmm0, -{{[0-9]+}}(%rsp)
; AA-NEXT: vmovups %xmm0, (%rdi) ; AA-NEXT: vmovups %xmm0, (%rdi)
; AA-NEXT: retq ; AA-NEXT: retq
entry: entry:
%alloc = alloca [16 x i8], i8 2, align 1 %alloc = alloca [16 x i8], i8 2, align 1
%part2 = getelementptr inbounds [16 x i8], [16 x i8]* %alloc, i64 0, i64 0 %part2 = getelementptr inbounds [16 x i8], [16 x i8]* %alloc, i64 0, i64 0
%part1 = getelementptr inbounds [16 x i8], [16 x i8]* %alloc, i64 1, i64 0 %part1 = getelementptr inbounds [16 x i8], [16 x i8]* %alloc, i64 1, i64 0
Show All 9 Lines
define dso_local void @onealloc_readback_2(i8* nocapture %a, i8* nocapture %b) local_unnamed_addr { define dso_local void @onealloc_readback_2(i8* nocapture %a, i8* nocapture %b) local_unnamed_addr {
; NOAA-LABEL: onealloc_readback_2: ; NOAA-LABEL: onealloc_readback_2:
; NOAA: # %bb.0: # %entry ; NOAA: # %bb.0: # %entry
; NOAA-NEXT: vmovups (%rdi), %xmm0 ; NOAA-NEXT: vmovups (%rdi), %xmm0
; NOAA-NEXT: vmovaps %xmm0, -{{[0-9]+}}(%rsp) ; NOAA-NEXT: vmovaps %xmm0, -{{[0-9]+}}(%rsp)
; NOAA-NEXT: vmovups (%rsi), %xmm0 ; NOAA-NEXT: vmovups (%rsi), %xmm0
; NOAA-NEXT: vmovaps %xmm0, -{{[0-9]+}}(%rsp) ; NOAA-NEXT: vmovaps %xmm0, -{{[0-9]+}}(%rsp)
; NOAA-NEXT: vmovaps -{{[0-9]+}}(%rsp), %xmm0
; NOAA-NEXT: vmovups %xmm0, (%rdi) ; NOAA-NEXT: vmovups %xmm0, (%rdi)
; NOAA-NEXT: retq ; NOAA-NEXT: retq
; ;
; AA-LABEL: onealloc_readback_2: ; AA-LABEL: onealloc_readback_2:
; AA: # %bb.0: # %entry ; AA: # %bb.0: # %entry
; AA-NEXT: vmovups (%rdi), %xmm0
; AA-NEXT: vmovaps %xmm0, -{{[0-9]+}}(%rsp)
; AA-NEXT: vmovups (%rsi), %xmm0 ; AA-NEXT: vmovups (%rsi), %xmm0
; AA-NEXT: vmovaps %xmm0, -{{[0-9]+}}(%rsp) ; AA-NEXT: vmovaps %xmm0, -{{[0-9]+}}(%rsp)
; AA-NEXT: vmovups %xmm0, (%rdi) ; AA-NEXT: vmovups %xmm0, (%rdi)
; AA-NEXT: retq ; AA-NEXT: retq
entry: entry:
%alloc = alloca [16 x i8], i8 2, align 1 %alloc = alloca [16 x i8], i8 2, align 1
%part1 = getelementptr inbounds [16 x i8], [16 x i8]* %alloc, i64 0, i64 0 %part1 = getelementptr inbounds [16 x i8], [16 x i8]* %alloc, i64 0, i64 0
%part2 = getelementptr inbounds [16 x i8], [16 x i8]* %alloc, i64 1, i64 0 %part2 = getelementptr inbounds [16 x i8], [16 x i8]* %alloc, i64 1, i64 0
Show All 20 Lines