[IR] Create new method in the Function class (NFC)

[evandro]

Summary

Create method optForNaught() testing for -O0 and refactor appropriately.

[evandro]

Ping! 🔔

[spatel]

llvm/include/llvm/IR/Function.h

594 ↗

(On Diff #192379)

I understand that we're trying to mimic the existing 'optForSize' naming, but "optForNaught" is not obvious.
How about "isOptNone()"?

[evandro]

llvm/include/llvm/IR/Function.h

594 ↗

(On Diff #192379)

optForNone()? Though I don't feel strongly about it.

[spatel]

llvm/include/llvm/IR/Function.h

594 ↗

(On Diff #192379)

I'm still not reading that as obvious. When I see this in IR, I'm used to seeing the string "optnone", so it makes more sense to me that the query includes that string exactly. If others disagree, I won't block it though.

[evandro]

llvm/include/llvm/IR/Function.h

594 ↗

(On Diff #192379)

In an OCD way, I'm trying to preserve the existing pattern for such methods. 😌

[spatel]

Ok, LGTM...it's just a convenience wrapper, so if anyone feels like the name can be improved, feel free. My vote would still be "isOptNone" or "hasOptNone". If that doesn't match the existing API, then I'd say fix that too: "hasOptSize".

[evandro]

That's a good idea to follow up on, following the pattern of hasOptNone().

lib/CodeGen/CGCall.cpp

for (StringRef Attr : CodeGenOpts.DefaultFunctionAttrs) {
     StringRef Var, Value;
     std::tie(Var, Value) = Attr.split('=');
     FuncAttrs.addAttribute(Var, Value);
   }
 }
 
 void CodeGenModule::AddDefaultFnAttrs(llvm::Function &F) {
   llvm::AttrBuilder FuncAttrs;
-  ConstructDefaultFnAttrList(F.getName(),
-                             F.hasFnAttribute(llvm::Attribute::OptimizeNone),
+  ConstructDefaultFnAttrList(F.getName(), F.optForNone(),
                              /* AttrOnCallsite = */ false, FuncAttrs);
   F.addAttributes(llvm::AttributeList::FunctionIndex, FuncAttrs);
 }
 
 void CodeGenModule::ConstructAttributeList(
     StringRef Name, const CGFunctionInfo &FI, CGCalleeInfo CalleeInfo,
     llvm::AttributeList &AttrList, unsigned &CallingConv, bool AttrOnCallSite) {
   llvm::AttrBuilder FuncAttrs;