This is an extension to https://reviews.llvm.org/D55539 : promote constant offset to the immediate
to increase of the opportunity for loads.
Where are the _e32 versions coming from? I don't think you should be seeing these at this point.
You would need to verify the carry out is dead here. You should add a testcase where the vcc def of the add is used
This shouldn't include a call
The test could be a lot simpler
Do you mean the add AMDGPU::V_ADD_I32_e32 will actually been removed?
How to do this verification?
Do you mean in general a LIT test shouldn't include a call, or just this test case? I saw a lot in the existing lit tests.
.isDead() may be sufficient?
Lit tests should generally not involve calls unless the call is specifically being tested. They add a lot of code and test complexity, and since the ABI is going to change, they may not be stable.