Page MenuHomePhabricator

AMDGPU: Remove unnecessary check for isFullCopy
ClosedPublic

Authored by arsenm on Mar 25 2019, 7:36 AM.

Details

Reviewers
rampitec
Summary

Subregister indexes are not used for physical register operands, so
isFullCopy is implied by the physical register check.

Diff Detail

Event Timeline

arsenm created this revision.Mar 25 2019, 7:36 AM
This revision is now accepted and ready to land.Mar 25 2019, 10:20 AM
arsenm closed this revision.Mar 25 2019, 2:27 PM

r356956

Hi Matt,

This change introduces a regression with Overwatch and RADV (cf. https://bugs.freedesktop.org/show_bug.cgi?id=110476).

Here's the attached LLVM IR https://pastebin.com/raw/VqRF4unW

Can you have a look?
Thanks!

Hi Matt,

This change introduces a regression with Overwatch and RADV (cf. https://bugs.freedesktop.org/show_bug.cgi?id=110476).

Here's the attached LLVM IR https://pastebin.com/raw/VqRF4unW

Can you have a look?
Thanks!

r358890

Hi Matt,

This change introduces a regression with Overwatch and RADV (cf. https://bugs.freedesktop.org/show_bug.cgi?id=110476).

Here's the attached LLVM IR https://pastebin.com/raw/VqRF4unW

Can you have a look?
Thanks!

r358890

I confirm it's fixed, thanks a lot!