This is an archive of the discontinued LLVM Phabricator instance.

Differential D59614

[AMDGPU] Add missing dependency on BinaryFormat
AbandonedPublic

Authored by sbc100 on Mar 20 2019, 2:22 PM.

Details

Reviewers
tpr
sbc100
Summary

This broke the -DBUILD_SHARED_LIBS=ON build when the dependency
was added in rL356591 (https://reviews.llvm.org/D57028)

Diff Detail

Event Timeline

sbc100 created this revision.Mar 20 2019, 2:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 20 2019, 2:22 PM
Herald added subscribers: llvm-commits, aheejin, hiraditya and 9 others. · View Herald Transcript
sbc100 added a reviewer: tpr.Mar 20 2019, 2:23 PM
Harbormaster completed remote builds in B29414: Diff 191581.Mar 20 2019, 2:24 PM
kzhuravl added a comment.Mar 20 2019, 2:27 PM

Dup of D59610 ?

sbc100 accepted this revision.Mar 20 2019, 2:41 PM
This revision is now accepted and ready to land.Mar 20 2019, 2:41 PM
sbc100 abandoned this revision.Mar 26 2019, 6:43 PM

Revision Contents

PathSize
llvm/
lib/
Target/
AMDGPU/
Utils/
2 lines

Diff 191581

llvm/lib/Target/AMDGPU/Utils/LLVMBuild.txt

Show All 12 Lines
; http://llvm.org/docs/LLVMBuild.html ; http://llvm.org/docs/LLVMBuild.html
; ;
;===------------------------------------------------------------------------===; ;===------------------------------------------------------------------------===;
[component_0] [component_0]
type = Library type = Library
name = AMDGPUUtils name = AMDGPUUtils
parent = AMDGPU parent = AMDGPU
required_libraries = Core MC Support required_libraries = Core MC Support BinaryFormat
add_to_library_groups = AMDGPU add_to_library_groups = AMDGPU