This is an archive of the discontinued LLVM Phabricator instance.

Differential D59589

Python 2/3 compat: str vs basestring
ClosedPublic

Authored by serge-sans-paille on Mar 20 2019, 12:32 AM.

Download Raw Diff

Details

Reviewers

michaelplatings
labath
davide

Commits

rG0bc1447845a2: Python 2/3 compat: str vs basestring
rL356908: Python 2/3 compat: str vs basestring
rLLDB356908: Python 2/3 compat: str vs basestring

Diff Detail

Repository: rLLDB LLDB

Event Timeline

serge-sans-paille created this revision.Mar 20 2019, 12:32 AM

Herald added a project: Restricted Project. · View Herald TranscriptMar 20 2019, 12:32 AM

Herald added subscribers: lldb-commits, jdoerfert, arphaman. · View Herald Transcript

serge-sans-paille added a reviewer: labath.Mar 23 2019, 3:38 AM

labath added a reviewer: davide.Mar 25 2019, 5:14 AM

LGTM.

This revision is now accepted and ready to land.Mar 25 2019, 8:06 AM

Closed by commit rLLDB356908: Python 2/3 compat: str vs basestring (authored by serge_sans_paille). · Explain WhyMar 25 2019, 8:20 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

lldb/

examples/

summaries/

cocoa/

5 lines

5 lines

CFBinaryHeap.py

5 lines

CFDictionary.py

5 lines

5 lines

5 lines

5 lines

5 lines

Diff 191453

lldb/examples/summaries/cocoa/CFArray.py

Context not available.
	import lldb.formatters.metrics			import lldb.formatters.metrics
	import lldb.formatters.Logger			import lldb.formatters.Logger

				try:
				basestring
				except NameError:
				basestring = str

	statistics = lldb.formatters.metrics.Metrics()			statistics = lldb.formatters.metrics.Metrics()
	statistics.add_metric('invalid_isa')			statistics.add_metric('invalid_isa')
	statistics.add_metric('invalid_pointer')			statistics.add_metric('invalid_pointer')
Context not available.

lldb/examples/summaries/cocoa/CFBag.py

Context not available.
	import lldb.formatters.metrics			import lldb.formatters.metrics
	import lldb.formatters.Logger			import lldb.formatters.Logger

				try:
				basestring
				except NameError:
				basestring = str

	statistics = lldb.formatters.metrics.Metrics()			statistics = lldb.formatters.metrics.Metrics()
	statistics.add_metric('invalid_isa')			statistics.add_metric('invalid_isa')
	statistics.add_metric('invalid_pointer')			statistics.add_metric('invalid_pointer')
Context not available.

lldb/examples/summaries/cocoa/CFBinaryHeap.py

Context not available.
	import lldb.formatters.metrics			import lldb.formatters.metrics
	import lldb.formatters.Logger			import lldb.formatters.Logger

				try:
				basestring
				except NameError:
				basestring = str

	statistics = lldb.formatters.metrics.Metrics()			statistics = lldb.formatters.metrics.Metrics()
	statistics.add_metric('invalid_isa')			statistics.add_metric('invalid_isa')
	statistics.add_metric('invalid_pointer')			statistics.add_metric('invalid_pointer')
Context not available.

lldb/examples/summaries/cocoa/CFDictionary.py

Context not available.
	import lldb.formatters.metrics			import lldb.formatters.metrics
	import lldb.formatters.Logger			import lldb.formatters.Logger

				try:
				basestring
				except NameError
				basestring = str

	statistics = lldb.formatters.metrics.Metrics()			statistics = lldb.formatters.metrics.Metrics()
	statistics.add_metric('invalid_isa')			statistics.add_metric('invalid_isa')
	statistics.add_metric('invalid_pointer')			statistics.add_metric('invalid_pointer')
Context not available.

lldb/examples/summaries/cocoa/NSData.py

Context not available.
	import lldb.formatters.metrics			import lldb.formatters.metrics
	import lldb.formatters.Logger			import lldb.formatters.Logger

				try:
				basestring
				except NameError:
				basestring = str

	statistics = lldb.formatters.metrics.Metrics()			statistics = lldb.formatters.metrics.Metrics()
	statistics.add_metric('invalid_isa')			statistics.add_metric('invalid_isa')
	statistics.add_metric('invalid_pointer')			statistics.add_metric('invalid_pointer')
Context not available.

lldb/examples/summaries/cocoa/NSIndexSet.py

Context not available.
	import lldb.formatters.metrics			import lldb.formatters.metrics
	import lldb.formatters.Logger			import lldb.formatters.Logger

				try:
				basestring
				except NameError:
				basestring = str

	statistics = lldb.formatters.metrics.Metrics()			statistics = lldb.formatters.metrics.Metrics()
	statistics.add_metric('invalid_isa')			statistics.add_metric('invalid_isa')
	statistics.add_metric('invalid_pointer')			statistics.add_metric('invalid_pointer')
Context not available.

lldb/examples/summaries/cocoa/NSMachPort.py

Context not available.
	import lldb.formatters.metrics			import lldb.formatters.metrics
	import lldb.formatters.Logger			import lldb.formatters.Logger

				try:
				basestring
				except NameError:
				basestring =str

	statistics = lldb.formatters.metrics.Metrics()			statistics = lldb.formatters.metrics.Metrics()
	statistics.add_metric('invalid_isa')			statistics.add_metric('invalid_isa')
	statistics.add_metric('invalid_pointer')			statistics.add_metric('invalid_pointer')
Context not available.

lldb/examples/summaries/cocoa/NSSet.py

Context not available.
	import CFBag			import CFBag
	import lldb.formatters.Logger			import lldb.formatters.Logger

				try:
				basestring
				except NameError:
				basestring = str

	statistics = lldb.formatters.metrics.Metrics()			statistics = lldb.formatters.metrics.Metrics()
	statistics.add_metric('invalid_isa')			statistics.add_metric('invalid_isa')
	statistics.add_metric('invalid_pointer')			statistics.add_metric('invalid_pointer')
Context not available.