When implementing GNU style dumper for .gnu.version section, we should find symbol version name by vs_index.
|650 ↗||(On Diff #192434)|
You don't need to do this now, but could you in a separate patch please replace dot_gnu_version_sec and similar with LLVM-style names?
|672 ↗||(On Diff #192434)|
I think it's more in keeping with existing style not to bother with the const on non-reference parameters.
|682 ↗||(On Diff #192434)|
Nit: missing full stop.
|688 ↗||(On Diff #192434)|
|700 ↗||(On Diff #192434)|
Is std::string the right type to be returning here? This is a pointer into an existing block of strings, so I'd think a StringRef would be sufficient.