Page MenuHomePhabricator

Fix an out-of-bounds error in RegisterContextDarwin_arm64
ClosedPublic

Authored by labath on Mar 18 2019, 8:48 AM.

Details

Summary

gcc diagnoses this as "array subscript 63 is above array bounds of
'RegisterContextDarwin_arm64::VReg [32]'".

The correct fix seems to be subtracting the fpu register base index, but
I have no way of verifying that this actually works.

Diff Detail

Repository
rL LLVM

Event Timeline

labath created this revision.Mar 18 2019, 8:48 AM

Jason, what do you make of this? I believe the fix is pretty straight-forward, but since this does actually change behaviour, I think it would be good if you had a quick look at it first.

jasonmolenda accepted this revision.Tue, Mar 26, 12:01 PM

Sorry for not weighing in earlier, yes this is good.

This revision is now accepted and ready to land.Tue, Mar 26, 12:01 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptWed, Mar 27, 2:39 AM