This is an archive of the discontinued LLVM Phabricator instance.

Differential D59460

[MSP430] Use generic operand printer for modifiers
Needs ReviewPublic

Authored by INdek on Mar 16 2019, 10:32 AM.

Details

Reviewers
asl
mskvortsov
Summary

Fix Generic CodeGen test CodeGen/Generic/asm-large-immediate.ll by using the
generic operand printer when a modifier is given.

Diff Detail

Event Timeline

INdek created this revision.Mar 16 2019, 10:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2019, 10:32 AM
Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript
Harbormaster completed remote builds in B29258: Diff 190975.Mar 16 2019, 10:32 AM
lebedev.ri added a subscriber: lebedev.ri.Mar 16 2019, 10:51 AM

Is this NFC or is there a test missing?

INdek added a comment.EditedMar 16 2019, 11:21 AM

This test was failing with the MSP430 target: CodeGen/Generic/asm-large-immediate.ll.

Should I create a similar test and place it under the MSP430 tests?

lebedev.ri added a comment.Mar 16 2019, 11:29 AM
In D59460#1432174, @INdek wrote:

This test was failing with the MSP430 target: CodeGen/Generic/asm-large-immediate.ll.

Should I create a similar test and place it under the MSP430 tests?

It is probably best to add standalone test for this.
The Generic test will only test this if the default target arch is MSP430.

INdek updated this revision to Diff 190986.Mar 16 2019, 12:05 PM
  • Add test for MSP430 asm printing modifiers
Herald added a subscriber: eraman. · View Herald TranscriptMar 16 2019, 12:05 PM
Harbormaster completed remote builds in B29263: Diff 190986.Mar 16 2019, 12:05 PM
INdek retitled this revision from Use generic operand printer for modifiers to [MSP430] Use generic operand printer for modifiers.Mar 17 2019, 2:05 PM
asl edited reviewers, added: mskvortsov; removed: nlewycky.Mar 18 2019, 5:57 AM
INdek added a comment.Mar 30 2019, 5:18 AM

ping

Revision Contents

PathSize
llvm/
lib/
Target/
MSP430/
11 lines
test/
CodeGen/
MSP430/
11 lines

Diff 190986

llvm/lib/Target/MSP430/MSP430AsmPrinter.cpp

Show First 20 Lines • Show All 125 Lines • ▼ Show 20 Lines
} }
/// PrintAsmOperand - Print out an operand for an inline asm expression. /// PrintAsmOperand - Print out an operand for an inline asm expression.
/// ///
bool MSP430AsmPrinter::PrintAsmOperand(const MachineInstr *MI, unsigned OpNo, bool MSP430AsmPrinter::PrintAsmOperand(const MachineInstr *MI, unsigned OpNo,
unsigned AsmVariant, unsigned AsmVariant,
const char *ExtraCode, raw_ostream &O) { const char *ExtraCode, raw_ostream &O) {
// Does this asm operand have a single letter operand modifier? // Does this asm operand have a single letter operand modifier?
if (ExtraCode && ExtraCode[0]) if (ExtraCode && ExtraCode[0]) {
return true; // Unknown modifier. if (ExtraCode[1] != 0) return true; // Unknown modifier.
switch (ExtraCode[0]) {
default:
// See if this is a generic print operand
return AsmPrinter::PrintAsmOperand(MI, OpNo, AsmVariant, ExtraCode, O);
}
}
printOperand(MI, OpNo, O); printOperand(MI, OpNo, O);
return false; return false;
} }
bool MSP430AsmPrinter::PrintAsmMemoryOperand(const MachineInstr *MI, bool MSP430AsmPrinter::PrintAsmMemoryOperand(const MachineInstr *MI,
unsigned OpNo, unsigned AsmVariant, unsigned OpNo, unsigned AsmVariant,
const char *ExtraCode, const char *ExtraCode,
▲ Show 20 Lines • Show All 47 Lines • Show Last 20 Lines

llvm/test/CodeGen/MSP430/inline-asm-modifiers.ll

  • This file was added.
; RUN: llc -march=msp430 < %s | FileCheck %s
define void @test() {
entry:
; CHECK: add 10, r1
call void asm sideeffect "add ${0:c}, r1", "i"( i8 10 )
; CHECK: add -10, r1
call void asm sideeffect "add ${0:n}, r1", "i"( i8 10 )
ret void
}