Page MenuHomePhabricator

[MSP430] Use generic operand printer for modifiers
Needs ReviewPublic

Authored by INdek on Mar 16 2019, 10:32 AM.

Details

Reviewers
asl
mskvortsov
Summary

Fix Generic CodeGen test CodeGen/Generic/asm-large-immediate.ll by using the
generic operand printer when a modifier is given.

Event Timeline

INdek created this revision.Mar 16 2019, 10:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2019, 10:32 AM

Is this NFC or is there a test missing?

INdek added a comment.EditedMar 16 2019, 11:21 AM

This test was failing with the MSP430 target: CodeGen/Generic/asm-large-immediate.ll.

Should I create a similar test and place it under the MSP430 tests?

This test was failing with the MSP430 target: CodeGen/Generic/asm-large-immediate.ll.

Should I create a similar test and place it under the MSP430 tests?

It is probably best to add standalone test for this.
The Generic test will only test this if the default target arch is MSP430.

INdek updated this revision to Diff 190986.Mar 16 2019, 12:05 PM
  • Add test for MSP430 asm printing modifiers
INdek retitled this revision from Use generic operand printer for modifiers to [MSP430] Use generic operand printer for modifiers.Mar 17 2019, 2:05 PM
asl edited reviewers, added: mskvortsov; removed: nlewycky.Mar 18 2019, 5:57 AM