This is an archive of the discontinued LLVM Phabricator instance.

Restore comment regarding why Reloc::PIC_ can't be PIC
ClosedPublic

Authored by sbc100 on Mar 15 2019, 7:10 PM.

Reviewers

Commits

Summary

The original change back in rL29307 explained this but it was
lost somewhere along the way.

This revision is now accepted and ready to land.Mar 18 2019, 12:57 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

include/

llvm/

Support/

5 lines

	Show All 12 Lines

	#ifndef LLVM_SUPPORT_CODEGEN_H			#ifndef LLVM_SUPPORT_CODEGEN_H
	#define LLVM_SUPPORT_CODEGEN_H			#define LLVM_SUPPORT_CODEGEN_H

	namespace llvm {			namespace llvm {

	// Relocation model types.			// Relocation model types.
	namespace Reloc {			namespace Reloc {
				// Cannot be named PIC due to collision with -DPIC
	enum Model { Static, PIC_, DynamicNoPIC, ROPI, RWPI, ROPI_RWPI };			enum Model { Static, PIC_, DynamicNoPIC, ROPI, RWPI, ROPI_RWPI };
	}			}

	// Code model types.			// Code model types.
	namespace CodeModel {			namespace CodeModel {
	// Sync changes with CodeGenCWrappers.h.			// Sync changes with CodeGenCWrappers.h.
	enum Model { Tiny, Small, Kernel, Medium, Large };			enum Model { Tiny, Small, Kernel, Medium, Large };
	}			}

	namespace PICLevel {			namespace PICLevel {
	// This is used to map -fpic/-fPIC.			// This is used to map -fpic/-fPIC.
	enum Level { NotPIC=0, SmallPIC=1, BigPIC=2 };			enum Level { NotPIC=0, SmallPIC=1, BigPIC=2 };
	}			}

	namespace PIELevel {			namespace PIELevel {
	Show All 31 Lines