Page MenuHomePhabricator

[clang-tidy] add an overload for diag method that allows users to provide a diagnostic name rather than using the check name when building a diagnostic.
AbandonedPublic

Authored by htl on Mar 13 2019, 1:12 PM.

Event Timeline

htl created this revision.Mar 13 2019, 1:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 13 2019, 1:12 PM
JonasToth retitled this revision from Add an overload for ClangTidy's diag method that allows users to provide a diagnostic name rather than using the check name when building a diagnostic. to [clang-tidy] add an overload for diag method that allows users to provide a diagnostic name rather than using the check name when building a diagnostic..Mar 15 2019, 7:35 AM
JonasToth added a project: Restricted Project.

What is the reason you want this change to happen? I think this gives the chance to create inconsistencies which we should avoid.

htl abandoned this revision.Mar 17 2019, 10:22 AM

What is the reason you want this change to happen? I think this gives the chance to create inconsistencies which we should avoid.

Sorry this was a bit rushed. I was trying to pass some metadata in the diagnostic name so that another tool that uses the diagnostic name can perform some conditional evaluation based on the data. I will try coming up with a better plan and design for such a change.

Thank you