This is an archive of the discontinued LLVM Phabricator instance.

Delete dead code
ClosedPublic

Authored by zturner on Mar 12 2019, 3:34 PM.

Details

Summary

Most of these are Dump functions that are never called, but there is one instance of entire unused classes (DWARFDebugMacinfo and DWARFDebugMacinfoEntry) which are also unreferenced in the codebase).

Diff Detail

Repository
rLLDB LLDB

Event Timeline

zturner created this revision.Mar 12 2019, 3:34 PM

One one hand this seems fine to remove, but on the other hand — won't these functions come in handy to compare and debug differences between the LLDB and LLVM DWARF parsers, while we are switching over?

One one hand this seems fine to remove, but on the other hand — won't these functions come in handy to compare and debug differences between the LLDB and LLVM DWARF parsers, while we are switching over?

Maybe, but I'm not sure how useful it will actually be in practice to compare dump output that way. I feel like if we successfully parse the DWARF using LLVM's parser, and no tests on either side regress in the process, then it is probably sufficient to say that things worked.

Can you imagine a scenario where the two outputs meaningfully differ but the test suites passed anyway?

JDevlieghere accepted this revision.Mar 18 2019, 2:20 PM

Given that this is not tested (I don't see any tests being removed) this LGTM.

This revision is now accepted and ready to land.Mar 18 2019, 2:20 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 19 2019, 11:05 AM
source/Plugins/SymbolFile/DWARF/DWARFDebugMacinfoEntry.h