ELF: Simplify. NFCI.

[pcc]

Summary

We don't need to take a slice of SectionCommands in addOrphanSections()
because it is not modified until the end of the function.

[grimar]

LGTM

lld/trunk/ELF/LinkerScript.cpp

static OutputSection *addInputSec(StringMap<OutputSection *> &Map,
   }
 
   Sec = createSection(IS, OutsecName);
   return Sec;
 }
 
 // Add sections that didn't match any sections command.
 void LinkerScript::addOrphanSections() {
-  unsigned End = SectionCommands.size();
   StringMap<OutputSection *> Map;
   std::vector<OutputSection *> V;
 
   auto Add = [&](InputSectionBase *S) {
     if (!S->Live || S->Parent)
       return;
 
     StringRef Name = getOutputSectionName(S);
 
     if (Config->OrphanHandling == OrphanHandlingPolicy::Error)
       error(toString(S) + " is being placed in '" + Name + "'");
     else if (Config->OrphanHandling == OrphanHandlingPolicy::Warn)
       warn(toString(S) + " is being placed in '" + Name + "'");
 
-    if (OutputSection *Sec =
-            findByName(makeArrayRef(SectionCommands).slice(0, End), Name)) {
+    if (OutputSection *Sec = findByName(SectionCommands, Name)) {
       Sec->addSection(cast<InputSection>(S));
       return;
     }
 
     if (OutputSection *OS = addInputSec(Map, S, Name))
       V.push_back(OS);
     assert(S->getOutputSection()->SectionIndex == UINT32_MAX);
   };