This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Do not force building with -fPIC
ClosedPublic

Authored by ldionne on Mar 8 2019, 11:49 AM.

Details

Summary

Whether we build with -fPIC should be specified by the
CMAKE_POSITION_INDEPENDENT_CODE option at configure time.
Note that this patch doesn't change the behavior when building
by default, since -fPIC is used for shared libraries by default.

Diff Detail

Repository
rCXX libc++

Event Timeline

ldionne created this revision.Mar 8 2019, 11:49 AM
smeenai accepted this revision.Mar 8 2019, 1:30 PM
smeenai added a subscriber: smeenai.

LGTM

This revision is now accepted and ready to land.Mar 8 2019, 1:30 PM
This revision was automatically updated to reflect the committed changes.