This is an archive of the discontinued LLVM Phabricator instance.

Differential D59052

ELF: Remove dead code. NFCI.
ClosedPublic

Authored by pcc on Mar 6 2019, 2:23 PM.

Details

Reviewers
ruiu
• espindola
Commits
rGb5a307fa244f: ELF: Remove dead code. NFCI.
rL355893: ELF: Remove dead code. NFCI.
rLLD355893: ELF: Remove dead code. NFCI.
Summary

The Live bit is already set to false by SectionBase.

Diff Detail

Event Timeline

pcc created this revision.Mar 6 2019, 2:23 PM
Herald added a reviewer: • espindola. · View Herald TranscriptMar 6 2019, 2:23 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: MaskRay, arichardson, emaste. · View Herald Transcript
Harbormaster completed remote builds in B28859: Diff 189595.Mar 6 2019, 2:24 PM
ruiu accepted this revision.Mar 11 2019, 4:53 PM

LGTM

This revision is now accepted and ready to land.Mar 11 2019, 4:53 PM
Closed by commit rLLD355893: ELF: Remove dead code. NFCI. (authored by pcc). · Explain WhyMar 11 2019, 7:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lld/
ELF/
4 lines

Diff 189595

lld/ELF/OutputSections.cpp

Show First 20 Lines • Show All 63 Lines • ▼ Show 20 Linesvoid OutputSection::writeHeaderTo(typename ELFT::Shdr *Shdr) {
Shdr->sh_addr = Addr; Shdr->sh_addr = Addr;
Shdr->sh_size = Size; Shdr->sh_size = Size;
Shdr->sh_name = ShName; Shdr->sh_name = ShName;
} }
OutputSection::OutputSection(StringRef Name, uint32_t Type, uint64_t Flags) OutputSection::OutputSection(StringRef Name, uint32_t Type, uint64_t Flags)
: BaseCommand(OutputSectionKind), : BaseCommand(OutputSectionKind),
SectionBase(Output, Name, Flags, /*Entsize*/ 0, /*Alignment*/ 1, Type, SectionBase(Output, Name, Flags, /*Entsize*/ 0, /*Alignment*/ 1, Type,
/*Info*/ 0, /*Link*/ 0) { /*Info*/ 0, /*Link*/ 0) {}
Live = false;
}
// We allow sections of types listed below to merged into a // We allow sections of types listed below to merged into a
// single progbits section. This is typically done by linker // single progbits section. This is typically done by linker
// scripts. Merging nobits and progbits will force disk space // scripts. Merging nobits and progbits will force disk space
// to be allocated for nobits sections. Other ones don't require // to be allocated for nobits sections. Other ones don't require
// any special treatment on top of progbits, so there doesn't // any special treatment on top of progbits, so there doesn't
// seem to be a harm in merging them. // seem to be a harm in merging them.
static bool canMergeToProgbits(unsigned Type) { static bool canMergeToProgbits(unsigned Type) {
▲ Show 20 Lines • Show All 346 Lines • Show Last 20 Lines