This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] LTO: Don't include bitcode-only symbols in the symtab
ClosedPublic

Authored by sbc100 on Mar 5 2019, 10:24 PM.

Event Timeline

sbc100 created this revision.Mar 5 2019, 10:24 PM
sbc100 added a reviewer: ruiu.Mar 5 2019, 10:25 PM

Hey @ruiu, do you know how we can stop herrald from adding @espindola as reviewer on all these CLs? My understanding is that he in no longer involved with the project.

pcc added a subscriber: pcc.Mar 6 2019, 10:27 AM
pcc added inline comments.
lld/wasm/Writer.cpp
953

Can this just be if (Sym->IsUsedInRegularObj)? AFAICT this flag is not set on lazy symbols (nor should it be).

sbc100 updated this revision to Diff 189538.Mar 6 2019, 10:49 AM
sbc100 marked 2 inline comments as done.
  • feedback
lld/wasm/Writer.cpp
953

Thanks! Done.

pcc accepted this revision.Mar 6 2019, 6:03 PM

LGTM

This revision is now accepted and ready to land.Mar 6 2019, 6:03 PM
This revision was automatically updated to reflect the committed changes.