Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
This comment was removed by aheejin.
Comment Actions
Seems reasonable, although the trailing white space in the ll files (i imagine because I can't figure out how to see the the diff in phabricator) is most likely due to the fact the yaml output of obj2yaml often includes trailing white space so when using copy and paste to include output check trailing whitespce is often introduced. I'm OK with it being removed, but I'm also OK with trailing whitespace in the CHECK: lines if that whitespace is present in the output that is being checked. I guess we should try to fix obj2yaml, although the beefit would be pretty tiny.