This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Remove trailing whitespaces in tests (NFC)
ClosedPublic

Authored by aheejin on Mar 4 2019, 11:09 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

aheejin created this revision.Mar 4 2019, 11:09 PM
aheejin retitled this revision from [WebAssembly] Remove trailing whitespaces (NFC) to [WebAssembly] Remove trailing whitespaces in tests (NFC).Mar 4 2019, 11:48 PM
aheejin edited the summary of this revision. (Show Details)

Ping. I guess this should be ok right?

This comment was removed by aheejin.
sbc100 accepted this revision.Mar 5 2019, 4:37 PM

Seems reasonable, although the trailing white space in the ll files (i imagine because I can't figure out how to see the the diff in phabricator) is most likely due to the fact the yaml output of obj2yaml often includes trailing white space so when using copy and paste to include output check trailing whitespce is often introduced. I'm OK with it being removed, but I'm also OK with trailing whitespace in the CHECK: lines if that whitespace is present in the output that is being checked. I guess we should try to fix obj2yaml, although the beefit would be pretty tiny.

This revision is now accepted and ready to land.Mar 5 2019, 4:37 PM
This revision was automatically updated to reflect the committed changes.