Page MenuHomePhabricator

PHI nodes are not `FPMathOperator` s
ClosedPublic

Authored by sanjoy on Mar 3 2019, 1:59 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

sanjoy created this revision.Mar 3 2019, 1:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2019, 1:59 PM
arsenm added a subscriber: arsenm.Mar 3 2019, 8:26 PM

Test case?

Test case?

I need this in a dependent change which has a test that fails without this fix. I can also add a C++ unit test in this change if you think that will help (I don't see an obvious way to test this using llvm-lit).

I think unit tests are good for this sort of thing

sanjoy updated this revision to Diff 189178.Mar 4 2019, 11:39 AM

Add unit test

arsenm accepted this revision.Mar 4 2019, 12:57 PM

LGTM

This revision is now accepted and ready to land.Mar 4 2019, 12:57 PM
sanjoy updated this revision to Diff 189203.Mar 4 2019, 2:14 PM

Matt, I noticed a necessary change I had to make before landing this separately.
I didn't notice this because I was initially testing this combined with some
other changes.

arsenm accepted this revision.Mar 4 2019, 4:45 PM
This revision was automatically updated to reflect the committed changes.