This is an archive of the discontinued LLVM Phabricator instance.

[ADT] Add llvm::binary_search to STLExtras
AbandonedPublic

Authored by Szelethus on Mar 3 2019, 8:59 AM.

Details

Diff Detail

Event Timeline

Szelethus created this revision.Mar 3 2019, 8:59 AM
dblaikie accepted this revision.Mar 4 2019, 7:00 AM

I guess maybe we have unit testsn for some but not all of these wrappers - might be worth checking/sampling to see what the prevailing trend is (I tend to be over-enthusiastic about testing, but I realize these simple wrappers are pretty uneventful)

include/llvm/ADT/STLExtras.h
1313

std::move(C), just in case it's cheaper to move?

This revision is now accepted and ready to land.Mar 4 2019, 7:00 AM
Szelethus abandoned this revision.May 23 2019, 5:27 AM

D60779 beat me to it :)